Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] langtool.py not working with the CONTRIBUTING.md syntax & inaccuracies #1775

Open
1 task done
Nixuge opened this issue Jun 29, 2024 · 0 comments
Open
1 task done
Labels
bug Something isn't working

Comments

@Nixuge
Copy link

Nixuge commented Jun 29, 2024

Operating System

Linux

What's the issue you encountered?

The syntax python3 dist/langtool.py create plugins/builtin/romfs/lang <iso_code> doesn't seem to be working anymore (error: unrecognized arguments: plugins/builtin/romfs/lang <iso_code>)

Instead you need to use
python3 dist/langtool.py create --langdir plugins/builtin/romfs/lang --lang <iso_code>
(or just python3 dist/langtool.py create --lang <iso_code> for everything)

Haven't tried the translate but ig the same issue occurs

Not PRing as i'm not sure if that's a me issue or nah (apparently been like this for a long time & no one complaining?) but doesn't look like it, can make one if needed

Also unsure if ISO 639-1 is the right format as it seems to be just 2 letters representing the language while the existing translation files are using ICU Locales (combination of ISO 639- lowercase language & ISO 3166- uppercase country)

Could also be nice to have an indication to put the language/country names in English & not in the language you're translating to while being prompted to enter those

How can the issue be reproduced?

All said above

ImHex Version

x.x.x

ImHex Build Type

  • Nightly or built from sources

Installation type

git

Additional context?

No response

@Nixuge Nixuge added the bug Something isn't working label Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant