Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueError: val_set must contain 'X_ori' for model validation. #533

Open
1 of 2 tasks
petteriTeikari opened this issue Oct 2, 2024 · 0 comments
Open
1 of 2 tasks
Labels
bug Something isn't working

Comments

@petteriTeikari
Copy link

1. System Info

pypots: 0.8.1

2. Information

  • The official example scripts
  • My own created scripts

3. Reproduction

Use dataset_val in addition to the dataset (train_set) in the usage instructions

4. Expected behavior

Not sure which one you meant to be the correct key, but your documentation [1] says that there should be X in the dictinary, whereas your code says there should be X_ori [2]

And I guess the validation split needs to contain both X () and X_ori (without the missing values) which is not given in the documentation [1]?

e.g.

dataset_val = {"X": X_val_gt_missing, "X_ori": X_val_gt}

[1] https://docs.pypots.com/en/latest/pypots.imputation.html#pypots.imputation.csdi.CSDI.fit

[2]
image
image

@petteriTeikari petteriTeikari added the bug Something isn't working label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant