Skip to content

Commit d1d4e6d

Browse files
authored
Raise the minimum support python version to v3.8 (#436)
* depen: raise the minimum support python version to v3.8;
1 parent b073c9e commit d1d4e6d

File tree

5 files changed

+15
-28
lines changed

5 files changed

+15
-28
lines changed

.github/workflows/testing_ci.yml

+7-13
Original file line numberDiff line numberDiff line change
@@ -19,21 +19,14 @@ jobs:
1919
strategy:
2020
fail-fast: false
2121
matrix:
22-
os: [ubuntu-latest, windows-latest, macOS-13]
23-
python-version: ["3.7", "3.11"]
22+
os: [ubuntu-latest, windows-latest, macOS-latest]
23+
python-version: ["3.8", "3.11"]
24+
pytorch-version: ["2.3.0"]
2425

2526
steps:
2627
- name: Check out the repo code
2728
uses: actions/checkout@v3
2829

29-
- name: Determine the PyTorch version
30-
uses: haya14busa/action-cond@v1
31-
id: determine_pytorch_ver
32-
with:
33-
cond: ${{ matrix.python-version == 3.7 }}
34-
if_true: "1.13.1"
35-
if_false: "2.1.0"
36-
3730
- name: Set up Python
3831
uses: actions/setup-python@v4
3932
with:
@@ -43,13 +36,14 @@ jobs:
4336
cache-dependency-path: |
4437
setup.cfg
4538
46-
- name: Install PyTorch ${{ steps.determine_pytorch_ver.outputs.value }}+cpu
39+
- name: Install PyTorch ${{ matrix.pytorch-version }}+cpu
4740
# we have to install torch in advance because torch_sparse needs it for compilation,
4841
# refer to https://github.com/rusty1s/pytorch_sparse/issues/156#issuecomment-1304869772 for details
4942
run: |
5043
which python
5144
which pip
52-
pip install torch==${{ steps.determine_pytorch_ver.outputs.value }} -f https://download.pytorch.org/whl/cpu
45+
pip install --upgrade
46+
pip install numpy==1.24 torch==${{ matrix.pytorch-version }} -f https://download.pytorch.org/whl/cpu
5347
python -c "import torch; print('PyTorch:', torch.__version__)"
5448
5549
- name: Install other dependencies
@@ -64,7 +58,7 @@ jobs:
6458
6559
- name: Continue to install torch-geometric dependencies
6660
run: |
67-
pip install torch-geometric torch-scatter torch-sparse -f "https://data.pyg.org/whl/torch-${{ steps.determine_pytorch_ver.outputs.value }}+cpu.html"
61+
pip install torch-geometric torch-scatter torch-sparse -f "https://data.pyg.org/whl/torch-${{ matrix.pytorch-version }}+cpu.html"
6862
pip install pypots[dev]
6963
python_site_path=`python -c "import site; print(site.getsitepackages()[0])"`
7064
echo "python site-packages path: $python_site_path"

README.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
<p align="center">
1010
<a href="https://docs.pypots.com/en/latest/install.html#reasons-of-version-limitations-on-dependencies">
11-
<img alt="Python version" src="https://img.shields.io/badge/Python-v3.7+-E97040?logo=python&logoColor=white">
11+
<img alt="Python version" src="https://img.shields.io/badge/Python-v3.8+-E97040?logo=python&logoColor=white">
1212
</a>
1313
<a href="https://github.com/WenjieDu/PyPOTS">
1414
<img alt="powered by Pytorch" src="https://img.shields.io/badge/PyTorch-%E2%9D%A4%EF%B8%8F-F8C6B5?logo=pytorch&logoColor=white">
@@ -177,8 +177,8 @@ With PyGrinder, you can introduce synthetic missing values into your datasets wi
177177
<img src="https://pypots.com/figs/pypots_logos/BenchPOTS/logo_FFBG.svg" align="left" width="140" alt="BenchPOTS logo"/>
178178
</a>
179179

180-
👈 To fairly evaluate the performance of PyPOTS algorithms, the benchmarking suite [BenchPOTS](https://github.com/WenjieDu/BenchPOTS) is created,
181-
which provides standard and unified data-preprocessing pipelines to prepare datasets for measuring the performance of different
180+
👈 To fairly evaluate the performance of PyPOTS algorithms, the benchmarking suite [BenchPOTS](https://github.com/WenjieDu/BenchPOTS) is created,
181+
which provides standard and unified data-preprocessing pipelines to prepare datasets for measuring the performance of different
182182
POTS algorithms on various tasks.
183183

184184
<a href="https://github.com/WenjieDu/BrewPOTS">

README_zh.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
<p align="center">
1010
<a href="https://docs.pypots.com/en/latest/install.html#reasons-of-version-limitations-on-dependencies">
11-
<img alt="Python version" src="https://img.shields.io/badge/Python-v3.7+-E97040?logo=python&logoColor=white">
11+
<img alt="Python version" src="https://img.shields.io/badge/Python-v3.8+-E97040?logo=python&logoColor=white">
1212
</a>
1313
<a href="https://github.com/WenjieDu/PyPOTS">
1414
<img alt="powered by Pytorch" src="https://img.shields.io/badge/PyTorch-%E2%9D%A4%EF%B8%8F-F8C6B5?logo=pytorch&logoColor=white">

docs/install.rst

+3-10
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ It is recommended to use **pip** or **conda** for PyPOTS installation as shown b
2020
2121
Required Dependencies
2222
"""""""""""""""""""""
23-
* Python >=3.7
23+
* Python >=3.8
2424
* h5py
2525
* numpy
2626
* scipy
@@ -44,25 +44,18 @@ Optional Dependencies
4444

4545
Reasons of Version Limitations on Dependencies
4646
**********************************************
47-
* **Why we need python >=3.7?**
47+
* **Why we need python >=3.8?**
4848

4949
Python v3.6 and before versions have no longer been supported officially (check out `status of Python versions here <https://devguide.python.org/versions/>`_).
5050
Besides, PyG (torch-geometric) is available for Python >= v3.7 (refer to https://pytorch-geometric.readthedocs.io/en/latest/install/installation.html#installation-via-anaconda ).
5151
Although torch-geometric is an optional dependency, we hope things go smoothly when our users opt to install it.
52-
5352
In addition, note that Python v.3.7 has also been in the end-of-life status since 2023-06-27.
54-
Hence, we will raise the minimum support Python version to v3.8 in the future.
55-
Please use Python v3.8 or above if possible also for the security of your development environment.
53+
Hence, we raise the minimum support Python version to v3.8.
5654

5755
* **Why we need PyTorch >=1.10?**
5856

5957
Because of pytorch_sparse, please refer to https://github.com/rusty1s/pytorch_sparse/issues/207#issuecomment-1065549338.
6058

61-
* **Why we need TSDB >=0.2 and PyGrinder >=0.4?**
62-
Since v0.2, all libraries in PyPOTS Ecosystem switch their licenses from GPL-v3-only to BSD-3-Clause, which has less constraints for users.
63-
Please refer to the discussion in issue `PyPOTS#227 <https://github.com/WenjieDu/PyPOTS/issues/227>`_ for details.
64-
65-
6659
Acceleration
6760
""""""""""""
6861
GPU Acceleration

setup.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@
6060
"pygrinder>=0.6",
6161
"benchpots>=0.1",
6262
],
63-
python_requires=">=3.7.0",
63+
python_requires=">=3.8.0",
6464
setup_requires=["setuptools>=38.6.0"],
6565
entry_points={"console_scripts": ["pypots-cli=pypots.cli.pypots_cli:main"]},
6666
classifiers=[

0 commit comments

Comments
 (0)