Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Being error-free with vanilla Laravel #10

Open
szepeviktor opened this issue Apr 6, 2018 · 4 comments
Open

Being error-free with vanilla Laravel #10

szepeviktor opened this issue Apr 6, 2018 · 4 comments

Comments

@szepeviktor
Copy link

Hello!

Are there plans to get an error-free analysis of vanilla Laravel (5.5/5.6)?

@szepeviktor
Copy link
Author

szepeviktor commented Apr 6, 2018

Currently with Laravel 5.5:
vendor/bin/phpstan analyse --configuration=./phpstan.neon --level=7 -- app/

 ------ -----------------------------------------------------------------------------------------------------------
  Line   app/Providers/RouteServiceProvider.php
 ------ -----------------------------------------------------------------------------------------------------------
  54     Method Illuminate\Support\Facades\Route::group() invoked with 1 parameter, 2 required.
  54     Parameter #1 $attributes of method Illuminate\Support\Facades\Route::group() expects array, string given.
  68     Method Illuminate\Support\Facades\Route::group() invoked with 1 parameter, 2 required.
  68     Parameter #1 $attributes of method Illuminate\Support\Facades\Route::group() expects array, string given.
 ------ -----------------------------------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------------------
  Line   app/Http/Controllers/Auth/RegisterController.php
 ------ --------------------------------------------------------------------------------------------------
  65     Method App\Http\Controllers\Auth\RegisterController::create() should return App\User but returns
         App\User|Illuminate\Database\Eloquent\Model.
 ------ --------------------------------------------------------------------------------------------------

@szepeviktor
Copy link
Author

Not being a Laravel expert I think Eloquent Query Scopes are not supported. (mainly Dynamic ones)

@szepeviktor szepeviktor changed the title Plans Being error-free with vanilla Laravel Apr 20, 2018
@szepeviktor
Copy link
Author

@Ascendens How do you see it?

@3onyc
Copy link
Contributor

3onyc commented May 10, 2018

Should we just create individual issues per warning that can then be associated with the milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants