Skip to content

Commit 30c9bcf

Browse files
dt-jean-baptiste-lemeedt-jean-baptiste-lemee
committed
Escape characters on xml attributes
1 parent ec5ce84 commit 30c9bcf

File tree

13 files changed

+118
-15
lines changed

13 files changed

+118
-15
lines changed

‎cjs/interface/document.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ const {NodeList} = require('./node-list.js');
3434
const {Range} = require('./range.js');
3535
const {Text} = require('./text.js');
3636
const {TreeWalker} = require('./tree-walker.js');
37+
const {XmlAttr} = require('./xml-attr.js');
3738

3839
const query = (method, ownerDocument, selectors) => {
3940
let {[NEXT]: next, [END]: end} = ownerDocument;
@@ -170,7 +171,7 @@ class Document extends NonElementParentNode {
170171
return this[EVENT_TARGET];
171172
}
172173

173-
createAttribute(name) { return new Attr(this, name); }
174+
createAttribute(name) { return this[MIME].isXml ? new XmlAttr(this, name) : new Attr(this, name); }
174175
createComment(textContent) { return new Comment(this, textContent); }
175176
createDocumentFragment() { return new DocumentFragment(this); }
176177
createDocumentType(name, publicId, systemId) { return new DocumentType(this, name, publicId, systemId); }

‎cjs/interface/xml-attr.js‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
'use strict';
2+
const {VALUE} = require('../shared/symbols.js');
3+
const {emptyAttributes} = require('../shared/attributes.js');
4+
const {Attr} = require('./attr.js');
5+
const {escape} = require('html-escaper');
6+
7+
/**
8+
* @implements globalThis.Attr
9+
*/
10+
class XmlAttr extends Attr {
11+
constructor(ownerDocument, name, value = '') {
12+
super(ownerDocument, name, value);
13+
}
14+
15+
toString() {
16+
const {name, [VALUE]: value} = this;
17+
return emptyAttributes.has(name) && !value ?
18+
name : `${name}="${escape(value)}"`;
19+
}
20+
}
21+
exports.XmlAttr = XmlAttr

‎cjs/shared/mime.js‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,26 +7,31 @@ const Mime = {
77
'text/html': {
88
docType: '<!DOCTYPE html>',
99
ignoreCase: true,
10+
isXml: false,
1011
voidElements: /^(?:area|base|br|col|embed|hr|img|input|keygen|link|menuitem|meta|param|source|track|wbr)$/i
1112
},
1213
'image/svg+xml': {
1314
docType: '<?xml version="1.0" encoding="utf-8"?>',
1415
ignoreCase: false,
16+
isXml: true,
1517
voidElements
1618
},
1719
'text/xml': {
1820
docType: '<?xml version="1.0" encoding="utf-8"?>',
1921
ignoreCase: false,
22+
isXml: true,
2023
voidElements
2124
},
2225
'application/xml': {
2326
docType: '<?xml version="1.0" encoding="utf-8"?>',
2427
ignoreCase: false,
28+
isXml: true,
2529
voidElements
2630
},
2731
'application/xhtml+xml': {
2832
docType: '<?xml version="1.0" encoding="utf-8"?>',
2933
ignoreCase: false,
34+
isXml: true,
3035
voidElements
3136
}
3237
};

‎esm/interface/attr.js‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {ATTRIBUTE_NODE} from '../shared/constants.js';
1+
import {ATTRIBUTE_NODE,QUOTE} from '../shared/constants.js';
22
import {CHANGED, VALUE} from '../shared/symbols.js';
33
import {String} from '../shared/utils.js';
44
import {attrAsJSON} from '../shared/jsdon.js';
@@ -9,8 +9,6 @@ import {attributeChangedCallback as ceAttributes} from './custom-element-registr
99

1010
import {Node} from './node.js';
1111

12-
const QUOTE = /"/g;
13-
1412
/**
1513
* @implements globalThis.Attr
1614
*/

‎esm/interface/document.js‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ import {NodeList} from './node-list.js';
3434
import {Range} from './range.js';
3535
import {Text} from './text.js';
3636
import {TreeWalker} from './tree-walker.js';
37+
import {XmlAttr} from './xml-attr.js';
3738

3839
const query = (method, ownerDocument, selectors) => {
3940
let {[NEXT]: next, [END]: end} = ownerDocument;
@@ -170,7 +171,7 @@ export class Document extends NonElementParentNode {
170171
return this[EVENT_TARGET];
171172
}
172173

173-
createAttribute(name) { return new Attr(this, name); }
174+
createAttribute(name) { return this[MIME].isXml ? new XmlAttr(this, name) : new Attr(this, name); }
174175
createComment(textContent) { return new Comment(this, textContent); }
175176
createDocumentFragment() { return new DocumentFragment(this); }
176177
createDocumentType(name, publicId, systemId) { return new DocumentType(this, name, publicId, systemId); }

‎esm/interface/xml-attr.js‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
import {VALUE} from '../shared/symbols.js';
2+
import {emptyAttributes} from '../shared/attributes.js';
3+
import {escape} from 'html-escaper';
4+
import {Attr} from './attr.js';
5+
6+
/**
7+
* @implements globalThis.Attr
8+
*/
9+
export class XmlAttr extends Attr {
10+
constructor(ownerDocument, name, value = '') {
11+
super(ownerDocument, name, value);
12+
}
13+
14+
toString() {
15+
const {name, [VALUE]: value} = this;
16+
return emptyAttributes.has(name) && !value ?
17+
name : `${name}="${escape(value)}"`;
18+
}
19+
}

‎esm/shared/constants.js‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,3 +29,9 @@ export const DOCUMENT_POSITION_IMPLEMENTATION_SPECIFIC = 0x20;
2929

3030
// SVG
3131
export const SVG_NAMESPACE = 'http://www.w3.org/2000/svg';
32+
33+
// Characters
34+
export const QUOTE = /"/g;
35+
export const LT = /</g;
36+
export const GT = />/g;
37+
export const AMPERSAND = /&/g;

‎esm/shared/mime.js‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,26 +6,31 @@ export const Mime = {
66
'text/html': {
77
docType: '<!DOCTYPE html>',
88
ignoreCase: true,
9+
isXml: false,
910
voidElements: /^(?:area|base|br|col|embed|hr|img|input|keygen|link|menuitem|meta|param|source|track|wbr)$/i
1011
},
1112
'image/svg+xml': {
1213
docType: '<?xml version="1.0" encoding="utf-8"?>',
1314
ignoreCase: false,
15+
isXml: true,
1416
voidElements
1517
},
1618
'text/xml': {
1719
docType: '<?xml version="1.0" encoding="utf-8"?>',
1820
ignoreCase: false,
21+
isXml: true,
1922
voidElements
2023
},
2124
'application/xml': {
2225
docType: '<?xml version="1.0" encoding="utf-8"?>',
2326
ignoreCase: false,
27+
isXml: true,
2428
voidElements
2529
},
2630
'application/xhtml+xml': {
2731
docType: '<?xml version="1.0" encoding="utf-8"?>',
2832
ignoreCase: false,
33+
isXml: true,
2934
voidElements
3035
}
3136
};

‎test/xml/document.js‎

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,28 @@ const assert = require('../assert.js').for('XMLDocument');
22

33
const {DOMParser} = global[Symbol.for('linkedom')];
44

5-
const document = (new DOMParser).parseFromString('<root></root>', 'text/xml');
5+
{
6+
const document = (new DOMParser).parseFromString('<root></root>', 'text/xml');
67

7-
assert(document.toString(), '<?xml version="1.0" encoding="utf-8"?><root />');
8+
assert(document.toString(), '<?xml version="1.0" encoding="utf-8"?><root />');;
89

9-
assert(document.documentElement.tagName, 'root');
10-
assert(document.documentElement.nodeName, 'root');
10+
assert(document.documentElement.tagName, 'root');
11+
assert(document.documentElement.nodeName, 'root');
1112

1213

13-
document.documentElement.innerHTML = `
14+
document.documentElement.innerHTML = `
1415
<Something>
1516
<Element>Text</Element>
1617
<Element>Text</Element>
1718
</Something>
1819
`.trim();
1920

20-
assert(document.querySelectorAll('Element').length, 2, 'case sesntivive 2');
21-
assert(document.querySelectorAll('element').length, 0, 'case sesntivive 0');
21+
assert(document.querySelectorAll('Element').length, 2, 'case sensitive 2');
22+
assert(document.querySelectorAll('element').length, 0, 'case sensitive 0');
23+
}
24+
25+
{
26+
const document = (new DOMParser).parseFromString('<root checked attr="&amp;&lt;&gt;"></root>', 'text/xml');
27+
assert(document.toString(), '<?xml version="1.0" encoding="utf-8"?><root checked attr="&amp;&lt;&gt;" />');
28+
}
29+

‎types/esm/interface/xml-attr.d.ts‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
/**
2+
* @implements globalThis.Attr
3+
*/
4+
export class XmlAttr extends Attr implements globalThis.Attr {
5+
}
6+
import { Attr } from "./attr.js";

0 commit comments

Comments
 (0)