Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightercollective switched to optional dependency #252

Closed
wants to merge 1 commit into from

Conversation

8eecf0d2
Copy link

While I'm a big fan and do currently support on patreon - it seems a bit over the top to force the installation of the opencollective / lightercollective package (now much smaller but that's not really the point).

This change will allow people to pass the --no-optional flag when installing to prevent optionals from being installed.

side note: lightercollective feature doesn't work with yarn.

@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling c7accc1 on 8eecf0d2:master into 686221a on WebReflection:master.

@WebReflection
Copy link
Owner

it seems a bit over the top to force the installation of the opencollective / lightercollective package

no open collective is needed, lightercollective is 4KB

(now much smaller but that's not really the point).

that is the whole point.

side note: lightercollective feature doesn't work with yarn.

if you support this project, you might rather help with making this work on yarn too.

As quick reminder:

  • the lightercollective is never required, so bundlers won't bother with it
  • the lightercollective weights nothing, so your network won't bother with it
  • right today the 0.1.0 uses the logo within the package, which logo weights more than lightercollective itself, but it doesn't need network to work (as long as you have the npm package)

I've closed before people asking me to drop what's absolutely irrelevant for them, but a valid Open Source way to wave everyone out there Open Source doesn't mean free.

Unless convinced otherwise this is an issue, I don't think it's even nice, as supporter of the project, to be ever bothered by a tiny log while installing.

@8eecf0d2
Copy link
Author

that is the whole point.

That's the point of lightercollective which is great, but not the point of my pull request.

Either way I understand and will hopefully be able to contribute in a more meaningful way in the future.

@8eecf0d2
Copy link
Author

yarn postinstall stdout ref: yarnpkg/yarn#5476

@WebReflection
Copy link
Owner

On a second though, the postinstall script runs lightercollective so if it's not there, there would be an error, right? For the time being I'll close this as wont fix, but if you have a solution for optional and postscript based on optional that doesn't error, I might eventually consider.

Yet, I really struggle to understand what is the issue in having a logo and a link to support software you are using and only while installing it, which is once in a while, not daily (and automations won't read the log, and won't ever care).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants