Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo review changes #93

Closed
8 tasks
2byrds opened this issue Feb 15, 2024 · 2 comments
Closed
8 tasks

Demo review changes #93

2byrds opened this issue Feb 15, 2024 · 2 comments
Assignees

Comments

@2byrds
Copy link
Collaborator

2byrds commented Feb 15, 2024

  • Abbreviated identifiers should have hover over to see the full identifier
  • On identifier creation, if there is a failure, supply an error message
  • Session can be interrupted while the app is running, this needs a fix or clever way to prompt user to reconnect.
  • All screens need a way to notify user if disconnected or some other error.
  • The credential 'Select' button needs more padding
  • The identifier 'Select' button needs more padding
  • Credential 'sign-in' button should not wrap
  • The example webapp should navigate to a welcome screen once sign-in successful. The welcome screen should tell the user what they signed in with and display the errors.
@HunnySajid
Copy link
Collaborator

HunnySajid commented Feb 15, 2024

  • Abbreviated identifiers should have hover over to see the full identifier
  • On identifier creation, if there is a failure, supply an error message
  • Session can be interrupted while the app is running, this needs a fix or clever way to prompt user to reconnect.
  • All screens need a way to notify user if disconnected or some other error.
  • The credential 'Select' button needs more padding
  • The identifier 'Select' button needs more padding
  • Credential 'sign-in' button should not wrap
  • The example webapp should navigate to a welcome screen once sign-in successful. The welcome screen should tell the user what they signed in with and display the errors.

All except session interruption and last point, rest are covered in #92

Separate task for session #96
Separate task for the last point #94

@HunnySajid
Copy link
Collaborator

Closing as it is merged with #92

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants