Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content Script Alerts UI #35

Closed
HunnySajid opened this issue Dec 22, 2023 · 6 comments
Closed

Content Script Alerts UI #35

HunnySajid opened this issue Dec 22, 2023 · 6 comments
Assignees

Comments

@HunnySajid
Copy link
Collaborator

No description provided.

@2byrds
Copy link
Collaborator

2byrds commented Jan 9, 2024

From our meeting today:

  • Instead of 'Signin' it should be 'Sign in', all over the extension.
  • Instead of alias 'holder' it should be 'Bank Employee'
  • 'Sign in with KERI' alert should show only the AID of the user tied to that webpage
  • 'Sign in with KERI' alert should have 'Select identifier' button if there are multiple sign ins with the page
  • The webpage needs to have a listener for the asynchronous message waiting for the user to do the sign in. @HunnySajid said it will be listening to 'send message' event. @rodolfomiranda will implement the functionality for the extension/backen, @HunnySajid will update the page to handle that properly.
  • 'Sign in with KERI' has a 'Create' button that should be removed and initiated automatically to the extension
  • The radio button for selection of Identifiers/Credentials looks odd
  • Once a sign in is selected, it should automatically sign in instead @rodolfomiranda will provide that. And will implement that.

@HunnySajid
Copy link
Collaborator Author

HunnySajid commented Jan 9, 2024

  • Instead of 'Signin' it should be 'Sign in', all over the extension.
  • Instead of alias 'holder' it should be 'Bank Employee'
  • 'Sign in with KERI' alert should show only the AID of the user tied to that webpage
  • 'Sign in with KERI' alert should have 'Select identifier' button if there are multiple sign ins with the page
  • The webpage needs to have a listener for the asynchronous message waiting for the user to do the sign in. @HunnySajid said it will be listening to 'send message' event. @rodolfomiranda will implement the functionality for the extension/backen, @HunnySajid will update the page to handle that properly.
  • 'Sign in with KERI' has a 'Create' button that should be removed and initiated automatically to the extension
  • The radio button for selection of Identifiers/Credentials looks odd
  • Once a sign in is selected, it should automatically sign in instead @rodolfomiranda will provide that. And will implement that.
  • Instead of 'Signin' it should be 'Sign in', all over the extension.

  • 'Sign in with KERI' alert should show only the AID of the user tied to that webpage

  • 'Sign in with KERI' alert should have 'Select identifier' button if there are multiple sign ins with the page

  • 'Sign in with KERI' has a 'Create' button that should be removed and initiated automatically to the extension

  • Instead of alias 'holder' it should be 'Bank Employee'
    @AlexAndrei98 please update the identifier's name from holder to Bank Employee

@2byrds I am working on some UI changes where the radio button would also be updated.

@2byrds
Copy link
Collaborator

2byrds commented Jan 9, 2024

  • Instead of 'Signin' it should be 'Sign in', all over the extension.
  • Instead of alias 'holder' it should be 'Bank Employee'
  • 'Sign in with KERI' alert should show only the AID of the user tied to that webpage
  • 'Sign in with KERI' alert should have 'Select identifier' button if there are multiple sign ins with the page
  • The webpage needs to have a listener for the asynchronous message waiting for the user to do the sign in. @HunnySajid said it will be listening to 'send message' event. @rodolfomiranda will implement the functionality for the extension/backen, @HunnySajid will update the page to handle that properly.
  • 'Sign in with KERI' has a 'Create' button that should be removed and initiated automatically to the extension
  • The radio button for selection of Identifiers/Credentials looks odd
  • Once a sign in is selected, it should automatically sign in instead @rodolfomiranda will provide that. And will implement that.
  • Instead of 'Signin' it should be 'Sign in', all over the extension.

  • 'Sign in with KERI' alert should show only the AID of the user tied to that webpage

  • 'Sign in with KERI' alert should have 'Select identifier' button if there are multiple sign ins with the page

  • 'Sign in with KERI' has a 'Create' button that should be removed and initiated automatically to the extension

  • Instead of alias 'holder' it should be 'Bank Employee'
    @AlexAndrei98 please update the identifier's name from holder to Bank Employee

@2byrds I am working on some UI changes where the radio button would also be updated.

Great thx @HunnySajid !

@2byrds
Copy link
Collaborator

2byrds commented Jan 10, 2024

From our meeting today:

  • The webapp must show what the authentication produces (signed headers should be shown to the user)
  • Holder should be 'Banker'
  • 'Select another credential' should go away in favor of the 'Select the KERI icon in your browser to proceed' message
  • 'Select the KERI icon in your browser to proceed' message should have 'KERI' themeing (KERI green text)
  • Consistent selection lists... meaning no radio button w/ a select button... instead an arrow denoting select, with text behind it for context.... so something like "Select >" or "Sign In >" etc.
  • Tighten the cards size, etc.
  • @rodolfomiranda will merge his PR and @HunnySajid will rebase it etc.

@2byrds
Copy link
Collaborator

2byrds commented Jan 11, 2024

Based on the demo, I believe this is complete. @HunnySajid will review and post the link to the recording and close the issue.

@2byrds
Copy link
Collaborator

2byrds commented Jan 11, 2024

#50

@2byrds 2byrds closed this as completed Jan 11, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants