Use class button-disabled instead of disabled="disabled" for <a> buttons #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix attr/removeAttr usage for 'disabled', 'checked', and 'selected'
jtsternberg
added a commit
that referenced
this pull request
Nov 17, 2014
…". Props @sc0ttkclark. commit 3709e957c41a63d2399578da7b55b33fad011217 Merge: 1702e1d ce235de Author: Justin Sternberg <[email protected]> Date: Mon Nov 17 10:54:24 2014 -0500 Merge branch 'hotfix/issue-63' of https://github.com/sc0ttkclark/CMB2 into sc0ttkclark-hotfix/issue-63 Conflicts: js/cmb2.min.js commit ce235de Author: Scott Kingsley Clark <[email protected]> Date: Thu Oct 30 01:17:04 2014 -0500 Check if remove button is disabled based on class, bail if so commit c92e984 Author: Scott Kingsley Clark <[email protected]> Date: Thu Oct 30 01:14:24 2014 -0500 Use class button-disabled instead of disabled="disabled" for <a> buttons Also fix attr/removeAttr usage for 'disabled', 'checked', and 'selected'
|
Merged: 5b8f511. Thanks @sc0ttkclark! |
jtsternberg
added a commit
that referenced
this pull request
Nov 24, 2014
…". Props @sc0ttkclark. commit 3709e957c41a63d2399578da7b55b33fad011217 Merge: 1702e1d ce235de Author: Justin Sternberg <[email protected]> Date: Mon Nov 17 10:54:24 2014 -0500 Merge branch 'hotfix/issue-63' of https://github.com/sc0ttkclark/CMB2 into sc0ttkclark-hotfix/issue-63 Conflicts: js/cmb2.min.js commit ce235de Author: Scott Kingsley Clark <[email protected]> Date: Thu Oct 30 01:17:04 2014 -0500 Check if remove button is disabled based on class, bail if so commit c92e984 Author: Scott Kingsley Clark <[email protected]> Date: Thu Oct 30 01:14:24 2014 -0500 Use class button-disabled instead of disabled="disabled" for <a> buttons Also fix attr/removeAttr usage for 'disabled', 'checked', and 'selected'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix attr/removeAttr usage for 'disabled', 'checked', and 'selected'
Resolves #63