Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename *.atomic.wake to *.atomic.notify? #104

Closed
binji opened this issue Sep 13, 2018 · 5 comments
Closed

Rename *.atomic.wake to *.atomic.notify? #104

binji opened this issue Sep 13, 2018 · 5 comments

Comments

@binji
Copy link
Member

binji commented Sep 13, 2018

JavaScript recently renamed Atomics.wake to Atomics.notify, see tc39/ecma262#1220. Should we do the same for the WebAssembly atomics instructions?

@conrad-watt
Copy link
Collaborator

conrad-watt commented Sep 14, 2018

As a counterpoint, OS APIs seem to tend towards "wake", either in name or documentation (wake_on_bit), (interrupting threads) and we've already diverged in convention from JS slightly on wait/wake to be closer to the OS (#36). Caught between two worlds!

@aheejin
Copy link
Member

aheejin commented Sep 14, 2018

We named those instructions in atomic.wake and atomic.notify in LLVM backend, to be consistent with JS, which of course does not have to be the same with real wasm instruction names though, as long as the binary opcodes are the same. So overall I'm in favor of the change.

@sunfishcode
Copy link
Member

(I don't have an opinion on which names, but with @aardappel's work, the LLVM wasm backend has been moving in the direction of harmonizing its text assembly format with the official wat format, so we really should use the same names, whatever they are, since that's the easy part :-)).

@rossberg
Copy link
Member

I have a slight preference for keeping wake, since it seems more common, its meaning is a bit more intuitive, and wake/wait makes the aesthetically nicer pair. :)

@aheejin
Copy link
Member

aheejin commented Nov 30, 2018

I guess we can close it now, after we decided to use *.atomic.notify in the Nov 13 CG meeting.

@aheejin aheejin closed this as completed Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants