New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recgroup binary encoding out of date #431

Closed

jakobkummerow opened this issue Sep 18, 2023 · 1 comment · Fixed by #435

Contributor

jakobkummerow commented Sep 18, 2023

@osa noticed that in the rendered spec (2023-09-13 draft version), the binary encoding for recgroups is outdated (after #372) and inconsistent with the rest of the spec. Specifically:

In the prose line "Recursive types are encoded by the byte 0x31 followed by a vector of sub types.", 0x31 should be 0x4E.
In the formal definition of rectype, the byte should be 0x4E (instead of 0x4F). (See https://webassembly.github.io/gc/core/appendix/index-types.html where it is correct.)
In the formal definition of subtype, the first byte of the "sub final" encoding should be 0x4F (instead of 0x4E).

The text was updated successfully, but these errors were encountered:

rossberg mentioned this issue

Fix rectype opcodes #435

Merged

Member

rossberg commented Sep 19, 2023

Indeed, thanks! PTAL at #435.

rossberg closed this as completed in #435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment