You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a really helpful module, but the comments it adds to output can cause problems for some JS and other systems.
One in particular is Magewire, which relies on one parent node in the HTML sections.
I suggest adding a setting to exclude controller routes or URLs from processing, so that we could have this module enabled except on requests to magewire/, or my/custom/ajax, or other routes as appropriate.
An alternative might be stripping top-level comments from output, but that would certainly cause other issues, and wouldn't necessarily solve all incompatibilities either.
Thanks!
The text was updated successfully, but these errors were encountered:
This is a really helpful module, but the comments it adds to output can cause problems for some JS and other systems.
One in particular is Magewire, which relies on one parent node in the HTML sections.
I suggest adding a setting to exclude controller routes or URLs from processing, so that we could have this module enabled except on requests to
magewire/
, ormy/custom/ajax
, or other routes as appropriate.An alternative might be stripping top-level comments from output, but that would certainly cause other issues, and wouldn't necessarily solve all incompatibilities either.
Thanks!
The text was updated successfully, but these errors were encountered: