Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put file and size constraints on what files can be added to meme editor #185

Open
0xjim opened this issue Sep 8, 2022 · 2 comments
Open
Assignees
Labels
need-design small < 1 day work. Can be put with another PR

Comments

@0xjim
Copy link
Contributor

0xjim commented Sep 8, 2022

SVG
GIF (up to 1MB?)
PNG
JPEG
JPG

Not allowed

  • mp4
  • pdf
@0xjim
Copy link
Contributor Author

0xjim commented Sep 8, 2022

Need Design to figure out where the copy should live.

@diegoprudencios
Copy link

diegoprudencios commented Sep 8, 2022

Added a copy below the buttons. The default state is black, and if users try to upload something not supported, it turns bold and red.

Here:
https://www.figma.com/file/wXczUcc9WlLtpuVJmHVYZm/Memixer---Fixes-1?node-id=1701%3A18928

Screenshot 2022-09-08 at 17 52 34

Screenshot 2022-09-08 at 18 02 09

@arttu0 arttu0 self-assigned this Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-design small < 1 day work. Can be put with another PR
Projects
Status: In Review (in Staging)
Development

No branches or pull requests

3 participants