chore: upstream sync #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Image generation service account <[email protected]> Co-authored-by: Actions service account <[email protected]>
Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Image generation service account <[email protected]> Co-authored-by: Actions service account <[email protected]>
Co-authored-by: Image generation service account <[email protected]> Co-authored-by: Actions service account <[email protected]>
Co-authored-by: Image generation service account <[email protected]> Co-authored-by: Actions service account <[email protected]>
Co-authored-by: Image generation service account <[email protected]> Co-authored-by: Actions service account <[email protected]>
Co-authored-by: Image generation service account <[email protected]> Co-authored-by: Actions service account <[email protected]>
) Co-authored-by: Image generation service account <[email protected]> Co-authored-by: Actions service account <[email protected]>
Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Image generation service account <[email protected]> Co-authored-by: Actions service account <[email protected]>
) Co-authored-by: Image generation service account <[email protected]> Co-authored-by: Actions service account <[email protected]>
…9862) The bug that prompted enabling 8.3 filename creation was fixed 5 years ago, see dotnet/android#3407: > Fix included in Xamarin.Android 10.1.0.30. > > Fix included on Windows in Visual Studio 2019 version 16.4. We're on VS 2019 16.11: https://github.com/actions/runner-images/blob/98150396188d19c21a7d7c596cf4a4d7609bb12a/images/windows/Windows2019-Readme.md?plain=1#L233 8.3 filename creation is known to hurt file creation performance, especially when there are a large number of similarly named files in the same folder: * https://learn.microsoft.com/en-us/archive/blogs/josebda/windows-server-2012-file-server-tip-disable-8-3-naming-and-strip-those-short-names-too * https://www.linkedin.com/pulse/dont-forget-disable-short-filenames-83-servers-folders-wes-brown * https://deep.data.blog/2013/06/19/debugging-story-slowness-due-to-ntfs-short-file-8-3-name-generation/ I created a new VM with the base Azure Marketplace Windows 2019 image and confirmed that 8.3 name generation is disabled by default for both the OS and temp disk: ``` fsutil 8dot3name query C: The volume state is: 1 (8dot3 name creation is disabled). The registry state is: 2 (Per volume setting - the default). Based on the above settings, 8dot3 name creation is disabled on C: fsutil 8dot3name query D: The volume state is: 1 (8dot3 name creation is disabled). The registry state is: 2 (Per volume setting - the default). Based on the above settings, 8dot3 name creation is disabled on D: ``` This might help a bit with actions/cache#752, although I haven't tested it, and AFAICT it's unlikely make an order of magnitude difference.
Co-authored-by: Image generation service account <[email protected]>
Co-authored-by: Image generation service account <[email protected]> Co-authored-by: Actions service account <[email protected]>
Co-authored-by: Image generation service account <[email protected]> Co-authored-by: Actions service account <[email protected]>
* [Windows] Update signature for Azure CosmosDb Emulator * Replace with SHA256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.