Skip to content

Commit

Permalink
refactor/skip ui tests on draft (#2620)
Browse files Browse the repository at this point in the history
  • Loading branch information
enesozturk authored Jul 30, 2024
1 parent 64fedae commit c2771a7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 29 deletions.
27 changes: 2 additions & 25 deletions .github/workflows/pr_checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ name: Checks

on:
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
branches:
- V3
- V4
Expand All @@ -17,31 +18,6 @@ concurrency:
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

jobs:
build:
runs-on: ubuntu-latest
timeout-minutes: 5
if: github.event.action == 'opened' || github.event.action == 'synchronize'
steps:
- name: checkout
uses: actions/checkout@v3

- uses: pnpm/action-setup@v4
name: Install pnpm

- name: setup-node
uses: actions/setup-node@v3
with:
node-version: 18.x
cache: 'pnpm'

- name: install
run: pnpm install

- name: build
run: pnpm build
env:
NEXT_PUBLIC_PROJECT_ID: ${{ secrets.NEXT_PUBLIC_PROJECT_ID }}

code_style:
runs-on: ubuntu-latest
permissions:
Expand Down Expand Up @@ -120,6 +96,7 @@ jobs:
json-summary-path: ./coverage/coverage-merged-summary.json

ui-test:
if: github.event.pull_request.draft == false
uses: ./.github/workflows/ui_tests.yml
secrets: inherit
permissions:
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/ui_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,6 @@ jobs:
id: playwright-version
run: echo "PLAYWRIGHT_VERSION=$(node -e "console.log(require('./package-lock.json').packages['apps/laboratory']['devDependencies']['@playwright/test'])")" >> $GITHUB_ENV

- name: Install Brave Browser
working-directory: ./apps/laboratory/
run: sudo ./scripts/install-brave-browser.sh

- name: Cache playwright binaries
uses: actions/cache@v4
id: playwright-cache
Expand Down

0 comments on commit c2771a7

Please sign in to comment.