Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App crash when set same symmetric key #358

Closed
lmcmz opened this issue Jul 21, 2022 · 2 comments · Fixed by #387
Closed

App crash when set same symmetric key #358

lmcmz opened this issue Jul 21, 2022 · 2 comments · Fixed by #387
Labels
bug Something isn't working

Comments

@lmcmz
Copy link

lmcmz commented Jul 21, 2022

Describe the bug

When I'm playing with demo app, the app crashed sometimes when connecting with demo dApp.
Is it possible to add try catch or throw here? without 2 force try in the code?
Or we can remove the the same key before we add it ?

SDK Version

  • Client: Swift
  • Version: commit -> 87be7e7

To Reproduce
Steps to reproduce the behavior:

  1. Go to demo wallet
  2. Scan QR code in demo dApp
  3. Click on Approve
  4. App crashed

Expected behavior
The SDK will handle the duplicate SymmetricKey

Screenshots
Screen Shot 2022-07-22 at 3 01 20 am

@lmcmz lmcmz added the bug Something isn't working label Jul 21, 2022
@flypaper0
Copy link
Contributor

@lmcmz thanks for bug report. Could you please attach detailed steps to reproduce crash. I tried your steps, but didn't catch the crash. I'm agree, we need to handle kms errors without for try, but looks like here something wrong in use cases

@lmcmz
Copy link
Author

lmcmz commented Jul 22, 2022

It's hard to reproduce, I just connect and reconnect the same wallet with the same dapp multiple times.
The duplicate pairing has been created, somehow, it crashes after scanning the QRCode.

@flypaper0 flypaper0 linked a pull request Aug 1, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants