This repository has been archived by the owner on Sep 24, 2018. It is now read-only.
WP_JSON_Users new_user method should be renamed to create_user #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rachelbaker
commented
Jul 27, 2014
rachelbaker
commented
- rename method
- include stub method
- update tests
Replaced new_user method name with create_user. Added stub method with deprecated notice for new_user.
| * @param $data | ||
| * @return mixed | ||
| */ | ||
| public function create_user( $data ) { |
There was a problem hiding this comment.
Already fixed and noticed :)
| @@ -100,15 +100,15 @@ public function test_create_user() { | |||
| $response_data = $response->get_data(); | |||
|
|
|||
| // Check that the data is intact | |||
| $new_user = get_userdata( $response_data['ID'] ); | |||
There was a problem hiding this comment.
These ones don't make sense, I think.
rmccue
added a commit
that referenced
this pull request
Jul 27, 2014
Rename WP_JSON_Users::new_user to create_user
kellbot
pushed a commit
to kellbot/WP-API
that referenced
this pull request
Aug 1, 2014
Rename WP_JSON_Users::new_user to create_user
Japh
pushed a commit
to Japh/WP-API
that referenced
this pull request
Sep 29, 2014
Fixes WP-API#376 git-svn-id: http://gsoc.svn.wordpress.org/2013/rmccue/trunk@2343 f69abe3c-2ee2-4550-9a6d-17bd458115be
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.