This repository has been archived by the owner on Sep 24, 2018. It is now read-only.
Split meta endpoints into separate class #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The filter is used in the prepare_post method, which only returns data. Any extra headers/etc need to be added in a higher level.
|
@rmccue is this ready for a #reviewmerge? |
|
@rachelbaker Hmm. Question is, what's the best way to handle CPTs and extensibility here? Thinking we might want a slight refactor before we merge. |
|
On second thoughts, I'm OK with this. @rachelbaker #reviewmerge |
Undefined method WP_JSON_Meta_Posts::handle_post_meta_action(). Renamed to new class method $this->handle_inline_meta().
Resolves issue where creating meta for a post_id was returning an error.
Resolves PHP warning that Headers were already sent from duplicate use of json_ensure_response on the the same response object.
rmccue
added a commit
that referenced
this pull request
Sep 2, 2014
Split meta endpoints into separate class
rachelbaker
added a commit
that referenced
this pull request
Sep 8, 2014
…t_meta() method. Helper methods for post_meta functionality that still occur within Post routes. First steps to fix functionality break in #358.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one half of #273.