This repository has been archived by the owner on Sep 24, 2018. It is now read-only.
Use wrapper for sanitize_title to avoid messed up slugs.
#2723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required sinse passing sanitize_title directly will result in messed up slugs due to the `context` param getting a garbage value.
|
Duplicate of #1712; should bring over the changes from there. |
| * @param string $slug | ||
| * @return string | ||
| */ | ||
| public function sanitize_slug( $slug ) { |
There was a problem hiding this comment.
This is going into core?
There was a problem hiding this comment.
Until the proper fix in https://core.trac.wordpress.org/ticket/34659 goes in, we still need to work around the bug.
There was a problem hiding this comment.
Ok. Could we add a note on the method then?
|
Updated with notes as above; @joehoyle happy with this? |
|
Looks good to me |
rmccue
approved these changes
Sep 27, 2016
kadamwhite
reviewed
Sep 27, 2016
| $new_data = $response->get_data(); | ||
| $this->assertEquals( 'test-accented-charaecters', $new_data['slug'] ); | ||
| $post = get_post( $new_data['id'] ); | ||
| $this->assertEquals( 'test-accented-charaecters', $post->post_name ); |
|
Wait no. D'oh :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required sinse passing sanitize_title directly will result in
messed up slugs due to the
contextparam getting a garbage value.Fixes #2487