Fix post taxonomy terms link urls #1447
Conversation
|
@WP-API/amigos #reviewmerge |
| @@ -1155,13 +1155,11 @@ protected function prepare_links( $post ) { | |||
| } | |||
|
|
|||
| if ( 'post_tag' === $tax ) { | |||
There was a problem hiding this comment.
We should remove this special case, I can pick up if you want @rachelbaker
There was a problem hiding this comment.
@joehoyle thank you, please do.
Fix post taxonomy terms link urls
|
Merged #1447 |
| @@ -1154,13 +1154,8 @@ protected function prepare_links( $post ) { | |||
| continue; | |||
| } | |||
|
|
|||
| if ( 'post_tag' === $tax ) { | |||
There was a problem hiding this comment.
Is there going to be some alignment on "tag" (rest_base) vs "post_tag" (slug)? I get that "post_tag" is "ugly," but who really cares? The API should be data-driven, and not make special cases for personal preferences. The more the API special-cases "tag", the less consistent it becomes. Please, I beg you, use $tax->slug everywhere.
There was a problem hiding this comment.
@jdolan this issue is about using the rest base, so your concern is not specifically here. However, as far as the API exposes data, you'll only ever see tag, not a mix - so I don't know why it's a big issue. Tags are not just for posts, so the name is confusing, that's my 2c anyway. This change just fixes one small inconsistency where we didn't use rest_base (where we always should be doing).
There was a problem hiding this comment.
It's an issue because rest_base is never exposed to the client. Nowhere in the JSON response for the taxonomy object does it include rest_base. It does, however, include the slug -- and slug is precisely what should be used to map to URIs. That's what slug is for. See #1381.
There was a problem hiding this comment.
I realize that. I just see more special casing to accommodate the rest_base mistake seeping into the code and it makes me cringe. This code doesn't even use rest_base from a constant or some other variable -- it just replicates it. If I'm a jerk for pointing this out, then I apologize.
There was a problem hiding this comment.
@jdolan rest_base is not about post_tag we have to support it for custom taxonomies too. If anything, this commit supports you argument, it is getting rid of special casing the case.
Fixes #1383
This was missed in #1216, where the routes for the Taxonomies and Terms for a Post moved.