Skip to content
This repository has been archived by the owner on Sep 24, 2018. It is now read-only.

Work with pretty permalinks disabled #138

Merged
merged 1 commit into from
Apr 21, 2014
Merged

Work with pretty permalinks disabled #138

merged 1 commit into from
Apr 21, 2014

Conversation

rmccue
Copy link
Member

@rmccue rmccue commented Apr 15, 2014

We should try and work with pretty permalinks disabled for compatibility's sake.

This supersedes #69.

@rmccue rmccue added this to the 1.0 milestone Apr 15, 2014
@rmccue rmccue self-assigned this Apr 15, 2014
@rmccue
Copy link
Member Author

rmccue commented Apr 15, 2014

@rachelbaker #reviewmerge

@rmccue
Copy link
Member Author

rmccue commented Apr 20, 2014

@rmccue During testing this patch still did not allow the JSON routes to respond without pretty permalinks enabled. This needs more debugging/testing.

Hmm. I have pretty permalinks disabled, and /?json_route=/ works. What were you using to test?

rachelbaker added a commit that referenced this pull request Apr 21, 2014
Respond to requests without depending on pretty permalink settings.  Fixes #69.
@rachelbaker rachelbaker merged commit 8a71737 into master Apr 21, 2014
@rachelbaker
Copy link
Member

@rmccue My fault. Tested and merged.

@rachelbaker rachelbaker deleted the ugly-permalinks branch May 1, 2014 22:11
kellbot pushed a commit to kellbot/WP-API that referenced this pull request Aug 1, 2014
Respond to requests without depending on pretty permalink settings.  Fixes WP-API#69.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants