-
Notifications
You must be signed in to change notification settings - Fork 4
Would you consider open sourcing this plugin? #4
Comments
@logan-connolly Hi! I'd be happy if you take the maintenance of the plugin under your possesion, because I no longer use gruvbox theme and don't plan to continue working on the plugin. |
I'm happy to maintain it, but perhaps @f4z3r is a better candidate as he wrote the light theme feature and has been active in the issues. I've been using this colorscheme for two years now, and I can't seem to move away from it :) So I'd be happy to maintain or contribute. I consider this plugin pretty much feature complete. So I'd like to limit changes to bug fixes like #3. I would also consider a refactor if it meant a sizable performance boost without changing the colorscheme output. As a prerequisite, I'd like to build out some tests first. If you don't have any objections, I would say let's set a permissive license like
Thanks again for making a beautiful colorscheme! |
Hi everyone First of all: also from me, thanks a lot @WIttyJudge for building this. I have been using this essentially since day 1 of me moving from vim to neovim, and absolutely love it! I would be happy to either contribute or maintain the repo if you no longer use the colorscheme, and if @logan-connolly has no time or desire to do so. I actually already maintain a private fork of it that fixes some minor issues for advanced usage with tree-sitter (plz don't sue me 😅). You seem to already have quite concrete ideas about a potential future for the project Logan. I'd be happy to help if you want, or take over the repo if you think it is a better idea. I love the scheme and don't plan on moving away from it. Let me know. |
The treesitter bug is my main gripe at the moment, and it looks like you have already made headway here. I think you are the perfect person for the job. I would be happy to fork and test your work.
Not many big ideas :D I think it is a nice colorscheme as is. I think the priority should be keeping the default appearance to users downstream and fixing bugs & improving performance. If there is a feature that people are excited about, perhaps it should be an optional configuration setting for people to opt into. I think you will do a great job at maintaining this plugin @f4z3r! |
Sorry for the late replies, I am in the mountains for a long weekend without much network coverage. Ok, perfect, I am happy to maintain it. @WIttyJudge do you want to transfer the ownership so we can keep the history/issues/references/etc of the repo, or would you rather that I fork it and you link to the fork here? I will be back at my laptop on Monday and can have a more in depth look. MIT license sounds perfect! 👍 |
@f4z3r Let's do the second option :) I'll put a link to your repository |
Alright. I updated my fork to your latest commit on master: https://github.com/f4z3r/gruvbox-material.nvim/tree/master @logan-connolly I will add you as contributor if you want. I might port some issues from here to the fork, and maybe create one or two additional ones (e.g. get the plugin added to Nixpkgs). |
@WIttyJudge do you mind archiving this repo? That way PRs will be disabled to your repo (since it will be read-only), and the default target of PRs on the fork will no longer be your repository. |
Actually never mind. I recreated the repo without forking so that it is independent 👍🏽 |
Hi @WIttyJudge, thank you so much for the awesome color scheme plugin! I would like to fork the repository and add some minor changes and fixes, but I noticed that there is no license defined. Would you consider adding an open source license to this project?
The text was updated successfully, but these errors were encountered: