Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How does zoom work with this feature? #58

Open
travisleithead opened this issue Apr 21, 2022 · 0 comments
Open

How does zoom work with this feature? #58

travisleithead opened this issue Apr 21, 2022 · 0 comments

Comments

@travisleithead
Copy link
Member

This issue has been migrated from MicrosoftEdge/MSEdgeExplainers#309

@BoCupp-Microsoft opened this issue on 2020-05-07

If I zoom the page should the title bar content get bigger? Maybe there is already a CSS mechanism to handle this?


@amandabaker commented on 2020-05-07

Following the existing pattern of the browser frame, I would not expect the overlay to change size when zooming the page. The overlay would match the size of the title bar on any other installed PWA

@aarongustafson commented on 2020-05-08

Good catch @BoCupp-Microsoft. As @amandabaker said, the overlay would not resize, but the web content acting as a title bar would. So you could end up with the title bar getting much larger (or even smaller) than the controls. As pixels are no longer fixed in dimension (i.e., they scale like other relative values) I'm not quite sure how you'd be able to force the title bar to remain at a consistent size (at least not without using JS to listen for a synthetic text resize event and then applying some logic to scale it up/down relative to the root font size and your target height). We should dig into this a bit more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant