Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Parsing & Compilation to Profiler Markers #71

Open
magenish opened this issue Feb 6, 2022 · 2 comments
Open

Adding Parsing & Compilation to Profiler Markers #71

magenish opened this issue Feb 6, 2022 · 2 comments

Comments

@magenish
Copy link

magenish commented Feb 6, 2022

The new markers feature going to be super helpful.

I believe adding parsing and compilation markers (both in time and defer) to it could be super helpful to understand the real cause of long JS and main thread bottlenecks.

Its s available in chromium devtools so i guess that something achievable.

@cnpsc
Copy link
Contributor

cnpsc commented Feb 7, 2022

Thanks for the feedback @magenish following up with @ArthurSonzogni in the TAG review ticket #61 .

@ArthurSonzogni
Copy link

Nothing that I can think of. Could you confirm those are dedicated to a single document and you won't be able to observe other documents this way? That would be my expectations, but I might be wrong.

Given that markers are already behind crossOriginIsolation, the documents of the page already "agreed" seeing their data to be potentially exposed to other documents of the page, via the Spectre vulnerability. So I guess, even if there was a risk of leaks, we could still argue this is not worse than the status-co in this case.

Still I would be more confident if one could say that this could not be used to observe others. I think it can't.

@mikewest, @shhnjk, @arturjanc FYI.


So we would get the following markers:

[               
  "script",     
  "gc",         
  "style",      
  "layout",     
  "paint",      
  "parsing",    
  "compilation",
  "other"       
]

What "parsing" refers to? I guess HTML + CSS + javascript. More?
What "compilation" refers to? I guess optimizing the javascript and wasm?

I think it would be nice explicitly what the name is about and discussing with folks about it, so that you won't regret the current API in the future.

@yoavweiss FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants