-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for additional context / dimensions in the crash report #14
Comments
I think that background/foreground status is certainly possible. JS stack traces are being tracked in #12, and should at least be included in Memory and number-of-shared-pages may have privacy issues, and I'm not sure that we can include those. Especially for browsers without full site/process isolation, this could easily leak information about a user's activity on unrelated websites. |
I think that the best signal for background/foreground would be the document's visibility state, so we could add a "visibilityState" key, with values "visible" or "hidden" to the reports. |
The problem with exposing the number of documents / pages which shared this crash is that it exposes additional information about the users browsing session beyond what was happening in the specific page which configured reporting. In browsers without origin isolation, this can expose the presence of pages on other origins which shared the process, and even with site- or origin isolation, may expose more than would normally be available to the page (notwithstanding the existence of meltdown-style memory attacks) It might be the case that with COOP/COEP isolation, a page would be able to tell how many other frames share its process even before a crash, and so we wouldn't be exposing anything new to report that during a crash. I'll have to see if I can verify that though. |
If we were to do #15, many of these might be reasonable for us to skip and let the page do it itself if that's relevant? For instance, if visibility is something that's relevant to my app's state, I could call the JS API in my app's Document count wouldn't be possible to get that way, so probably would need to be special-cased (or add an API for that instead of adding it here?) Memory is an interesting middle ground since there's no event on major changes. Polling |
The current web reporting payload contains context from the client at time of the crash. additional contextual information would help with debugging, primarily:
Other nice-to-have context information:
The text was updated successfully, but these errors were encountered: