Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moreStyleSheets needs better name #3

Closed
TakayoshiKochi opened this issue Feb 5, 2018 · 5 comments
Closed

moreStyleSheets needs better name #3

TakayoshiKochi opened this issue Feb 5, 2018 · 5 comments

Comments

@TakayoshiKochi
Copy link
Member

No description provided.

TakayoshiKochi added a commit to TakayoshiKochi/construct-stylesheets that referenced this issue Feb 6, 2018
All 5 inline issues are migrated to GitHub.

WICG#2
Shall we allow asynchronous style sheet parsing?

WICG#3
moreStyleSheets needs better name

WICG#4
Shall we include added stylesheets in `document.styleSheets`?

WICG#5
StyleSheetList will need to define a constructor, accepting a `sequence<StyleSheet>`.

WICG#18
Define how origin is determined for a constructed stylesheet
@calebdwilliams
Copy link

Yeah, moreStyleSheets feels sloppy and not really indicative to a developer what's actually happening under the hood. I like the idea of constructedStyleSheets, customStyleSheets (or somehow otherwise designating that it is equivalent to a user agent stylesheet) or elementStyleSheets as it gets to what the actual distinction between the lists are.

@TakayoshiKochi
Copy link
Member Author

This discussion should depend on how the constructed stylesheet would be used, and how it behaves against other existing stylesheets.

At this point, custom element default style seems the first customer of the constructed stylesheet, and it doesn't depend on how this name is defined.

@TakayoshiKochi
Copy link
Member Author

As of now WICG/webcomponents#468 is the primary use case of constructed stylesheet, and .moreStyleSheets is not necessary for now.

Once its use case is invented by someone, let's revisit and bikeshed for the name.

@calebdwilliams
Copy link

calebdwilliams commented Aug 28, 2018

This should be reopened per this pull request comment. There I suggested adoptedStyleSheets if this is to be a property of a document/document fragment/element that will essentially adopt an outside style sheet. This also accounts for potential CSS/JS imports and that use case.

@tabatkins tabatkins reopened this Aug 28, 2018
@rakina
Copy link
Member

rakina commented Aug 30, 2018

We decided on adoptedStyleSheets. Thanks @calebdwilliams!

@rakina rakina closed this as completed Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants