Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add randomly generated ID to reports for deduplication #231

Closed
wants to merge 2 commits into from
Closed

Add randomly generated ID to reports for deduplication #231

wants to merge 2 commits into from

Conversation

apasel422
Copy link
Collaborator

@apasel422 apasel422 commented Sep 22, 2021

Fixes #228


Preview | Diff

@apasel422 apasel422 closed this Sep 22, 2021
@apasel422 apasel422 reopened this Sep 28, 2021
@apasel422 apasel422 marked this pull request as ready for review September 28, 2021 22:37
@apasel422 apasel422 requested a review from johnivdel September 28, 2021 22:37
@apasel422 apasel422 changed the title Add nonce to reports for deduplication Add randomly generated ID to reports for deduplication Sep 29, 2021
@johnivdel
Copy link
Contributor

We should wait on getting some feedback on privacycg/private-click-measurement#92 first, but I am supportive of this.

@apasel422 apasel422 deleted the branch WICG:spec-report-delivery October 13, 2021 17:51
@apasel422 apasel422 closed this Oct 13, 2021
blueboxd pushed a commit to blueboxd/chromium-legacy that referenced this pull request Nov 19, 2021
…eduplication

This allows the report receiver to better detect retries in order to
avoid erroneous duplicate counting.

WICG/attribution-reporting-api#231

Change-Id: I041da2ba53492ae07fccca779a8532c016c35dc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3180180
Commit-Queue: Andrew Paseltiner <[email protected]>
Reviewed-by: John Delaney <[email protected]>
Cr-Commit-Position: refs/heads/main@{#943192}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants