Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI & migrate to mavenCentral #249

Merged
merged 3 commits into from
May 5, 2021
Merged

Fix CI & migrate to mavenCentral #249

merged 3 commits into from
May 5, 2021

Conversation

Mookiies
Copy link
Contributor

@Mookiies Mookiies commented Apr 30, 2021

Summary

  1. Bump joschi/setup-jdk from v1 to v2 (latest) to fix CI for android
  2. Swap jcenter with mavenCentral due to upcoming (feb 2022) jcenter deprecation: https://developer.android.com/studio/build/jcenter-migration. Done for library and example app.

Android CI Error

This error in the use specific Java version for sdk manager to work job is solved by version bump allowing for android builds to pass the github workflow

Error: Unable to process command '::set-env name=JAVA_HOME::/Users/runner/hostedtoolcache/AdoptOpenJDK/1.0.0-releases-openjdk8-hotspot-normal-latest/x64' successfully.
Error: The `set-env` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
Error: Unable to process command '::set-env name=JAVA_HOME_openjdk8_x64::/Users/runner/hostedtoolcache/AdoptOpenJDK/1.0.0-releases-openjdk8-hotspot-normal-latest/x64' successfully.
Error: The `set-env` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
Error: Unable to process command '::add-path::/Users/runner/hostedtoolcache/AdoptOpenJDK/1.0.0-releases-openjdk8-hotspot-normal-latest/x64/bin' successfully.
Error: The `add-path` command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the `ACTIONS_ALLOW_UNSECURE_COMMANDS` environment variable to `true`. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

Test Plan

Make CI Green + check Example app on both iOS and android simulators

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I've added Detox End-to-End Test(s)

@Mookiies
Copy link
Contributor Author

I also took a stab at fixing the iOS workflows failure but was unsuccessful so I created this issue #250

@reime005
Copy link
Collaborator

reime005 commented May 5, 2021

@Mookiies I think iOS can be fixed by this, could you test/ this in your branch?: 6fed07c

@Mookiies
Copy link
Contributor Author

Mookiies commented May 5, 2021

@reime005 That commit makes it pass the workflow 🎉

I've cherry-picked that commit and added it to this branch/pr

@Mookiies Mookiies changed the title Fix Android CI & migrate to mavenCentral Fix CI & migrate to mavenCentral May 5, 2021
@reime005
Copy link
Collaborator

reime005 commented May 5, 2021

@Mookiies Cool, thanks! Will merge

@reime005 reime005 merged commit c12a208 into Vydia:master May 5, 2021
github-actions bot pushed a commit that referenced this pull request May 5, 2021
## [6.2.1](v6.2.0...v6.2.1) (2021-05-05)

### Bug Fixes

* CI & migrate to mavenCentral ([#249](#249)) ([c12a208](c12a208))
@github-actions
Copy link

github-actions bot commented May 5, 2021

🎉 This PR is included in version 6.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

lucas31177 added a commit to lucas31177/react-native-upload that referenced this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants