Fix untracable crashes when URL is not parsable #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to NSURL checking compliance with RFC 2396 while parsing the url, sometimes when the URL is not compilant with the RFC it is considered `nil` and code throws this error. The problem is that this error is not caught anywhere, therefore crashing with a very unhelpful stack trace, as seen here: #121
github-actions bot
pushed a commit
that referenced
this pull request
Mar 22, 2020
## [5.2.1](v5.2.0...v5.2.1) (2020-03-22) ### Bug Fixes * ios - untracable crashes when URL is not parsable ([#183](#183)) ([a7c11f6](a7c11f6))
|
🎉 This PR is included in version 5.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
benjamin777dev
added a commit
to benjamin777dev/react-native-upload
that referenced
this pull request
Jun 10, 2024
## [5.2.1](Vydia/react-native-background-upload@v5.2.0...v5.2.1) (2020-03-22) ### Bug Fixes * ios - untracable crashes when URL is not parsable ([#183](Vydia/react-native-background-upload#183)) ([a7c11f6](Vydia/react-native-background-upload@a7c11f6))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to NSURL checking compliance with RFC 2396 while parsing the url, sometimes when the URL is not compilant with the RFC it is considered
niland code throws this error. The problem is that this error is not caught anywhere, therefore crashing with a very unhelpful stack trace, as seen here: #121