metrics namespace per reduction

[lalo]

Short description

Force reductions to only add metrics in their own namespace. The metrics output dictionary should then be some sort of dictionary[reduction_name_str, dictionary]

Possible solution/implementation details

It can be enforced at learner.h, before calling into the func pointer of persist metrics. You create a new namespace based on the name of the learner and its just a dictionary in json terms (metrics.cc)

Example/links if any

vowpal_wabbit/vowpalwabbit/core/include/vw/core/learner.h

Line 488 in 1098efd

this->learner_ptr->_persist_metrics_f = [fn_ptr, data](metric_sink& metrics) { fn_ptr(*data, metrics); };

[freyam]

I want to take this up. I will submit a PR after playing around and testing the patch thoroughly (roughly 1-2 days).

[adityakanu]

@lalo I am new to the community but this project seems interesting to me. And I believe this could be a good first issue for me to solve. Can you assign this to me?

[Gauravmauryaios]

Cann you please assign this project .