Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split apart reduction finish_example implementations #4307

Closed
45 tasks done
jackgerrits opened this issue Dec 5, 2022 · 0 comments
Closed
45 tasks done

Split apart reduction finish_example implementations #4307

jackgerrits opened this issue Dec 5, 2022 · 0 comments

Comments

@jackgerrits
Copy link
Member

jackgerrits commented Dec 5, 2022 •
edited
Loading

finish_example should be replaced with the appropriate implementations of output_prediction_example, print_update, update_stats and cleanup_example

finish_example currently usually contains several things, which we want to split into separate functions:

  • A call to shared_data::update-> Move to update_stats
  • A call to shared_data::print-> Move to print_update
  • Outputting predictions-> Move to output_prediction_example
  • Reusing memory or cleaning up the example -> cleanup_example

To migrate:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jackgerrits