Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normal feedback is returned to sender when daemon receives a malformed example #1597

Open
matanox opened this issue Sep 10, 2018 · 1 comment
Labels
Unintuitive Behavior Not a bug precisely, but a behavior that is surprising.

Comments

@matanox
Copy link

matanox commented Sep 10, 2018

A malformed (Contextual Bandits) context sent to VW will only log to the log file, but the sender will receive a normal response and have no way to know they are providing a malformed context string to the daemon. To reproduce on the comman-dline:

$ echo "| a: 0:300" | netcat localhost 26542

Assume in the above case, the sender intends to obtain a distribution back from the daemon, but the context they provide is, as easily seen above, malformed.

An error will be logged, but a distribution will be returned as if it is a normal message. This will deeply hinder production integration workflows that expect "plain" software standards on the socket↔daemon channel, and can be a source of trouble for production code architectures interacting with the daemon. The solution should probably (or perhaps) be to introduce a special response replacing the normal one.

Confirmed on 8.5 and 8.6.1 as released (in both cases model used in the daemon trained on 8.5).

Please let me know if you can indeed reproduce...

@JohnLangford
Copy link
Member

This seems very believable as a bug.

The core issue here is that there is no way for the daemon mode to report errors.

I'm not sure what to do about this. We aren't currently using the daemon mode, partly because more advanced communication protocols avoid this sort of failure.

@JohnLangford JohnLangford added the Unintuitive Behavior Not a bug precisely, but a behavior that is surprising. label Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Unintuitive Behavior Not a bug precisely, but a behavior that is surprising.
Projects
None yet
Development

No branches or pull requests

2 participants