Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests are not respecting conditional build #560

Open
ataymano opened this issue Feb 8, 2023 · 0 comments
Open

Unit tests are not respecting conditional build #560

ataymano opened this issue Feb 8, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@ataymano
Copy link
Member

ataymano commented Feb 8, 2023

RlClientLib can be built without azure factories (USE_AZURE_FACTORIES=Off), while unit test project (https://github.com/VowpalWabbit/reinforcement_learning/tree/master/unit_test) is not respecting that.

Azure factories specific tests should be hidden behind the same flag.
@ataymano ataymano added bug Something isn't working good first issue Good for newcomers labels Feb 8, 2023
@ataymano ataymano mentioned this issue Feb 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ataymano