Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build app for Linux #18

Open
dan-fritchman opened this issue Nov 10, 2022 · 3 comments
Open

Build app for Linux #18

dan-fritchman opened this issue Nov 10, 2022 · 3 comments

Comments

@dan-fritchman
Copy link
Collaborator

This has thus far only been tried in CI. And it's failed throughout. Example:

https://github.com/Vlsir/Hdl21Schematics/actions/runs/3434967680/jobs/5726793444

Note MacOS and Windows also run for each CI commit, and generally work.

@ThomasPluck
Copy link
Contributor

ThomasPluck commented Jan 14, 2023

Hi, so I'm attempting to build the Schematics editor on Ubuntu 22.04 LTS. I've found that the documented build process will leave the made files in out as naked shared object files and binary and not package them.

This is caused by the name attribute at the top of package.json somehow overriding the executableName that is explicitly stated in the packagerConfig as it I think it should be from debian packager docs. So I have no idea why that is happening, but the changing the name to match the executableName leaves me with a nice ~70MiB .deb and .rpm that I can move over to and install on a blank machine without any problems (also running Ubuntu 22.04 LTS).

I had none of these problems with the VS Code Extension due to a lack of a yarn.lock and not having this executableName issue. I am still sort of left wondering if the build worked exactly as it should have due to some issues like the disappearing side-bar (minimize once and then you'll never see it again).

Adding these changes to my own fork, I pass the current actions tests:

https://github.com/ThomasPluck/Hdl21Schematics/actions/runs/3919907721

@dan-fritchman
Copy link
Collaborator Author

OK interesting.
Our GitHub actions also try this, although I believe on the older Ubuntu v18. And as the issue intro would indicate, it fails.
You wanna put in a PR with what you changed? And what is it, the electron-forge version?

Re: the current electron-forge version - there is #24 on the topic. It largely boils down to "it's a weird version but the newer ones removed the debugging setup I like". Maybe it's time we just gotta let that debugging setup go.

Re: your observations in the VsCode extension - my guess is it "built right". While I envision VsCode as a central long-term mechanism, most debugging happens in the electron app, largely because, well, the debugging's much better. (And it's early days here! This didn't exist as of late August.) Notably we've got #3 on dark mode. More fertile ground for a PR!

@ThomasPluck
Copy link
Contributor

AFAIK runs-on: ubuntu-latest is the latest LTS distro of ubuntu (v22 right now). The issue as far as I understand it, is a simple misconfiguration problem for package.json inside of the EditorApp - I got other issues before with yarn.lock earlier, but this was a configuration issue on my end.

For now it builds and packages on the locked version, so I'll just leave well enough alone. I'll open a PR now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants