Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests #44

Open
Vlek opened this issue Jun 26, 2021 · 1 comment
Open

Refactor tests #44

Vlek opened this issue Jun 26, 2021 · 1 comment
Assignees
Labels
testing Testing
Milestone

Comments

@Vlek
Copy link
Owner

Vlek commented Jun 26, 2021

Problem:
Some of the tests could be rewritten better. Currently some are parameterized and others aren't. We also are capturing errors without specifying what errors we're supposed to be capturing.

Solution:

  • Go through and state what errors are thrown for which tests
  • Parameterize the tests that need it (Like modulus)

Considerations:

  • The errors may change in the future when we do better error handling that's more human friendly.
@Vlek
Copy link
Owner Author

Vlek commented Jul 14, 2021

One thing that I'm not doing that I probably should is ensure that the dice roll history is still there and that they're being appended correctly.

What I mean by that is the history of the entire dice string parsing should have the dice rolls be reflected in the EvaluationResults in the correct order. I am unsure if that means that all of the left-hand rolls go before or after the right-hand when doing operations or if it's the case that they need to be interleaved in some way. The latter would be difficult to do, as we would have to have some way of figuring out which actually came first. Whether that means that they need to have a timestamp or a counter attached to them, I'm not sure.

@Vlek Vlek self-assigned this Jul 15, 2021
@Vlek Vlek added the testing Testing label Jul 15, 2021
@Vlek Vlek added this to the 3.0 milestone Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Testing
Projects
None yet
Development

No branches or pull requests

1 participant