Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

historymap search #165

Open
kaidatavis opened this issue May 6, 2024 · 2 comments
Open

historymap search #165

kaidatavis opened this issue May 6, 2024 · 2 comments

Comments

@kaidatavis
Copy link
Collaborator

kaidatavis commented May 6, 2024

It will be good to be able to search nodes in a historymap, especially when there are many nodes.

This will be even better if the search goes through the entire page and not just the title, as the search text might not in the title. One library that can be used for this: https://github.com/nextapps-de/flexsearch

@kaidatavis kaidatavis changed the title full text search historymap search May 24, 2024
@Yuu-Han
Copy link
Collaborator

Yuu-Han commented Jun 8, 2024

(I really need this feature when I use historymap)

@kaidatavis
Copy link
Collaborator Author

kaidatavis commented Jul 8, 2024

Issue:

  1. Once historymap is updated, the current user location is lost (not just for search).
    1. check the behaviour if user clicks on a node in the search result: the new node should be added to the result node.
  2. whether to apply the search when the hmpages updates, such as user opens a new tab.
    1. maybe a search history so user can get back to a previous search results quickly.
  3. whether to include context in the search results.
  4. user may want to search a 'tag' because there are too many tags and not easy to find the one wanted.
  5. library can support certain type of fields, such as only search in the highlighted text, but probably too much for now.
  6. whether to 'combine' the same page in the search results, as a page can be visited many times. This is a general issue for historymap.
  7. Whether/how to highlight/differentiate the search results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants