-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activate tab on clicking tree node #148
Comments
It is easy to find and activate a page that has the same url with the node (or create a new one if it is already closed), but a bit tricky to maintain Considering the following scenario: The user navigated through multiple pages (i.e., p1, p2, ...) within the tab, which results in multiple
(There are similar issues with opening a closed page.) For option 1 & 2, new nodes are to be added from p1, but what if the user opens another p2' that has the same url with p2? is p2' going to be a new child node or should it be merged with p2? Also, if the tab |
Very good point. I think there are two parts of this, 1) where to (re)open the page/url, and 2) how to update the (internal) data structure (hmPages). For 1), my preference is probably open it in a new tab; updating an existing tab may cause the user to lose something that he/she still needs. For 2), it is a bit trickers. First, if user opens the same url in a new tab, I think this should be treated as a new node in historyMap. For example, user can open multiple google search pages and each for a different topic; it does not make much sense to me to include all the google search starting page as one node. I am not sure how best to update hmPages; maybe branch off from the old node will be the better option? We can discuss this at the meeting. |
This is completed. Clicking an opened page will activate the corresponding tab and clicking a closed page will open a new tab. The original hmPage object is updated (not adding a new node to hmPages). |
No description provided.
The text was updated successfully, but these errors were encountered: