From b52a1d72221ddd8386bc88df690f6bd4f6e879ff Mon Sep 17 00:00:00 2001
From: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
Date: Wed, 29 Sep 2021 16:50:55 -0400
Subject: [PATCH] Change OTLP/HTTP port from 4317 to 4318 (#1839) (#1970)

Related to https://github.com/open-telemetry/opentelemetry-specification/issues/1816
Fixes https://github.com/open-telemetry/opentelemetry-specification/issues/1835
Fixes https://github.com/open-telemetry/opentelemetry-specification/issues/1920

Some historical context: we wanted to make grpc and http use the same port and we
had an open issue in the Collector to do so:
https://github.com/open-telemetry/opentelemetry-collector/issues/1256

The conclusion is that there are technical hurdles that make it unfeasible:
https://github.com/open-telemetry/opentelemetry-collector/issues/1256#issuecomment-880048833

Because of that we need to keep grpc and http ports separate. This means we need to
change the spec to say that otlp/http uses port 4318. Once this PR is merged we
will also need to submit for port 4318 registration with IANA like we did previously
with port 4317:
https://github.com/open-telemetry/opentelemetry-specification/issues/1148#issuecomment-725067404

There was also a draft PR to merge the ports in the Collector but it was not completed:
https://github.com/open-telemetry/opentelemetry-collector/pull/3765

Note that this change was initially submitted in PR https://github.com/open-telemetry/opentelemetry-specification/pull/1839
and then reverted in PR https://github.com/open-telemetry/opentelemetry-specification/pull/1847
because we hoped that the merging could be successfully done. We believe that we should
no longer pursue this and should consider the ports separate from now on.

Note 2: we consider this a spec bug fix (spec was impossible to implement), rather than a
functionality change, that's why we believe this is an allowed change.
---
 specification/protocol/otlp.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/specification/protocol/otlp.md b/specification/protocol/otlp.md
index 0e5e6da0b..ff5f5679a 100644
--- a/specification/protocol/otlp.md
+++ b/specification/protocol/otlp.md
@@ -478,7 +478,7 @@ connections SHOULD be configurable.
 
 #### OTLP/HTTP Default Port
 
-The default network port for OTLP/HTTP is 4317.
+The default network port for OTLP/HTTP is 4318.
 
 ## Implementation Recommendations