Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: support pause reconciliation for vmcluster cr #943

Closed
just1900 opened this issue Apr 28, 2024 · 3 comments · Fixed by #947
Closed

Question: support pause reconciliation for vmcluster cr #943

just1900 opened this issue Apr 28, 2024 · 3 comments · Fixed by #947
Labels
enhancement New feature or request

Comments

@just1900
Copy link
Contributor

just1900 commented Apr 28, 2024

Consider adding support for pause reconciliation for vmcluster cr, similar to what have been done in vmalertmanager

Paused bool `json:"paused,omitempty"`

This feature would be helpful when performing operational tasks. I am willing to submit a pull request if you are open to merging this change. @f41gh7

@Haleygo
Copy link
Contributor

Haleygo commented Apr 29, 2024

Sounds like a good feature to all the components.
But I don't see any related implementation for VMAlertmanagerSpec.Paused now, seems like a unfinished TODO.
wdyt? @f41gh7

@Haleygo Haleygo added the enhancement New feature or request label Apr 29, 2024
@f41gh7
Copy link
Collaborator

f41gh7 commented Apr 30, 2024

Looks valuable feature to me. And good catch, currently Paused option is no-op for alertmanager.

@f41gh7
Copy link
Collaborator

f41gh7 commented May 10, 2024

Changes included to the v0.44.0 release

@f41gh7 f41gh7 closed this as completed May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants