Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmalertmanager config: validation for slack receiver URL #661

Closed
zekker6 opened this issue Jun 7, 2023 · 2 comments · Fixed by #662
Closed

vmalertmanager config: validation for slack receiver URL #661

zekker6 opened this issue Jun 7, 2023 · 2 comments · Fixed by #662

Comments

@zekker6
Copy link
Contributor

zekker6 commented Jun 7, 2023

Currently, in case receiver is configured via VMAlertmanagerConfig it uses reference to secret to pull slack URL:

- name: "slack-notifications"
  slack_configs:
    - channel: alerts
      api_url:
        key: slack_url
        name: slack-conf

In case secret contains some invalid URL it will lead to alertmanager being unable to start and enter CrashLoopBackoff quite easily.

It would be great if operator would validate that content of key in secret is valid URL and would not apply this change to alertmanager, but write an error in log/status field for created resource.
@Haleygo
Copy link
Contributor

Haleygo commented Jun 8, 2023

/assign

@Haleygo Haleygo mentioned this issue Jun 8, 2023
Merged
@f41gh7 f41gh7 reopened this Jun 10, 2023
@f41gh7
Copy link
Collaborator

f41gh7 commented Jul 3, 2023

Added at v0.35.0 release

@f41gh7 f41gh7 closed this as completed Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vmalertmanagerconfig: add validation for slack receiver url Haleygo/vm-operator
3 participants
@zekker6 @f41gh7 @Haleygo