fix(semver): Fixing pattern check for caret

Signed-off-by: Vincent Boutour <[email protected]>
ViBiOh · May 27, 2021 · fa548af · fa548af
1 parent bee0dc1
commit fa548af
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/pkg/semver/pattern.go b/pkg/semver/pattern.go
@@ -55,7 +55,7 @@ func (p Pattern) Check(version Version) bool {
 				return false
 			}
 		case lowerThan:
-			if !constraint.version.IsGreater(version) {
+			if version.IsGreater(constraint.version) || version.Equals(constraint.version) {
 				return false
 			}
 		}

diff --git a/pkg/semver/pattern_test.go b/pkg/semver/pattern_test.go
@@ -85,6 +85,14 @@ func TestCheck(t *testing.T) {
 			},
 			true,
 		},
+		{
+			"simple caret match",
+			safeParsePattern("^11"),
+			args{
+				version: safeParse("12"),
+			},
+			false,
+		},
 		{
 			"caret",
 			safeParsePattern("^1.0"),