Skip to content

Entity score filters don't seem to work #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ltbringer opened this issue Jul 2, 2021 · 0 comments · Fixed by #62
Closed

Entity score filters don't seem to work #60

ltbringer opened this issue Jul 2, 2021 · 0 comments · Fixed by #62
Assignees
Labels
bug Something isn't working

Comments

@ltbringer
Copy link
Contributor

Describe the bug
DucklingPlugin doesn't apply filters on score even when set.

Expected behavior
Entities with scores lower than the threshold were not filtered.

Desktop (please complete the following information):

  • OS: Ubuntu
  • Python version 3.8
  • Dialogy 0.6.5

Additional context
DucklingPlugin applies filters before aggregation. The filters rely on scores and these scores are generated in the aggregation step. This means score-based filtering won't be removing any entities.

@ltbringer ltbringer added the bug Something isn't working label Jul 2, 2021
@ltbringer ltbringer linked a pull request Jul 2, 2021 that will close this issue
This was linked to pull requests Jul 11, 2021
This was unlinked from pull requests Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants