Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Presence of mutate and reshape in DucklingParser #26

Closed
ltbringer opened this issue Apr 15, 2021 · 0 comments · Fixed by #28
Closed

Presence of mutate and reshape in DucklingParser #26

ltbringer opened this issue Apr 15, 2021 · 0 comments · Fixed by #28
Assignees
@ltbringer
Labels
Kludge Bad code decisions

Comments

@ltbringer
Copy link
Contributor

_mutate_entity and _reshape methods don't belong in DucklingParser. We need them to be implemented via .from_dict of individual entities.
@ltbringer ltbringer added the Kludge Bad code decisions label Apr 15, 2021
@ltbringer ltbringer self-assigned this Apr 15, 2021
@ltbringer ltbringer mentioned this issue Apr 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ltbringer ltbringer

Labels
Kludge Bad code decisions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test/#18/parametric tests skit-ai/dialogy
1 participant
@ltbringer