New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing some checks in the user program to add ? #35

Open

vletoux opened this issue Jun 30, 2021 · 0 comments

Contributor

vletoux commented Jun 30, 2021

I found out there is a couple of checks missing.

First:
https://github.com/Velocidex/WinPmem/blob/master/kernel/executable/winpmem.cpp#L422
If there is no more space on the disk, WriteFile Fails, then copy_memory fails, then write_raw_image succeed.
The status is not propagated at the end of the program (the %ERRORLEVEL% var)

Second:
https://github.com/Velocidex/WinPmem/blob/master/kernel/executable/main.cpp#L189
if the driver install fails, status will be negative and the program will stop.
But the final status will not be propagated at the end of the program (the %ERRORLEVEL% var)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment