From ca01528e437850aa9e322a684d77fe9868b65851 Mon Sep 17 00:00:00 2001
From: WeiN76LQh <WeiN76LQh@github.com>
Date: Sun, 23 Mar 2025 21:57:09 +0000
Subject: [PATCH] [SharedCache] Add a section for an image header

Similar to what is discussed in PR #6513 its useful to be able to see where an image header is as sometimes you want to inspect the load commands. Without a section its not very obvious where the header is.

The naming scheme of `${imageName}::__header` was chosen based on the naming choice of the DSC header.
---
 view/sharedcache/core/SharedCache.cpp | 36 +++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/view/sharedcache/core/SharedCache.cpp b/view/sharedcache/core/SharedCache.cpp
index e3c115cd0f..4b5ae3bc45 100644
--- a/view/sharedcache/core/SharedCache.cpp
+++ b/view/sharedcache/core/SharedCache.cpp
@@ -2422,8 +2422,28 @@ void SharedCache::InitializeHeader(
 	if (settings && settings->Contains("loader.dsc.processFunctionStarts"))
 		applyFunctionStarts = settings->Get<bool>("loader.dsc.processFunctionStarts", view);
 
+	// For identifying the span of memory containing the image header if it 
+	// hasn't already been initialized
+	uint64_t headerRegionEnd = 0;
+	MemoryRegion const* headerRegion = nullptr;
+	for (const auto& region : regionsToLoad)
+	{
+		if (region->start != header.textBase)
+			continue;
+		
+		if (!MemoryRegionIsHeaderInitialized(lock, *region))
+		{
+			headerRegion = region;
+			headerRegionEnd = region->start + region->size;
+		}
+		break;
+	}
+
 	for (size_t i = 0; i < header.sections.size(); i++)
 	{
+		if (headerRegion && header.sections[i].addr < headerRegionEnd)
+			headerRegionEnd = header.sections[i].addr;
+
 		bool skip = false;
 		for (const auto& region : regionsToLoad)
 		{
@@ -2549,6 +2569,22 @@ void SharedCache::InitializeHeader(
 			type, header.sections[i].align);
 	}
 
+	// If the memory region containing the header is not initialized and was 
+	// found then add a section for it
+	if (headerRegion && headerRegionEnd > headerRegion->start)
+	{
+		for (const auto& region : regionsToLoad)
+		{
+			if (region->start != header.textBase)
+				continue;
+
+			const auto headerSectionName = fmt::format("{}::__header", header.identifierPrefix);
+			view->AddUserSection(headerSectionName, region->start, headerRegionEnd - region->start, 
+				SectionSemanticsForRegion(*region));
+			break;
+		}
+	}
+
 	auto typeLib = view->GetTypeLibrary(header.installName);
 
 	BinaryReader virtualReader(view);