Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for displaying long strings by variable name #3583

Open
op2786 opened this issue Oct 21, 2022 · 3 comments
Open

Support for displaying long strings by variable name #3583

op2786 opened this issue Oct 21, 2022 · 3 comments
Labels
Component: UI Issue needs changes to the user interface Effort: Low Issue should take < 1 week Impact: Medium Issue is impactful with a bad, or no, workaround Type: Enhancement Issue is a small enhancement to existing functionality UI: Linear Issues with the Linear view UI: Strings Issues with the Strings widget or overall display of strings elsewhere

Comments

@op2786
Copy link
Contributor

op2786 commented Oct 21, 2022

In the example code below, "long str here.." is a lengthy global string variable that named long_str . Currently Binary Ninja displays summary annotation of it.

In some situations support for displaying strings with variable name would be useful. Maybe with Display As -> Variable Name?

int32_t status= login(v1 + 1, "long str hereeeeeeeeeeeeeeeeeee..", &this->login)
// with feature : int32_t status= login(v1 + 1, long_str, &this->login)
@op2786 op2786 added the Type: Enhancement Issue is a small enhancement to existing functionality label Oct 21, 2022
@CouleeApps
Copy link
Member

This gets complicated when there are auto analysis created symbols for strings. This is at odds with something like #2971 when the behavior opposite of this is desired. I'm not sure of a good heuristic that satisfies both of these.

@CouleeApps CouleeApps added the Component: UI Issue needs changes to the user interface label Oct 21, 2022
@psifertex
Copy link
Member

psifertex commented Oct 24, 2022

I don't think this issue is tracking a heuristic to "get it right" so much as offering the user the ability to control when each happens after the fact.

@plafosse plafosse added Effort: Low Issue should take < 1 week Impact: Medium Issue is impactful with a bad, or no, workaround labels Jan 2, 2023
@fuzyll fuzyll added UI: Strings Issues with the Strings widget or overall display of strings elsewhere UI: Linear Issues with the Linear view labels May 17, 2023
@plafosse
Copy link
Member

This issue is somewhat relevant: #2366

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: UI Issue needs changes to the user interface Effort: Low Issue should take < 1 week Impact: Medium Issue is impactful with a bad, or no, workaround Type: Enhancement Issue is a small enhancement to existing functionality UI: Linear Issues with the Linear view UI: Strings Issues with the Strings widget or overall display of strings elsewhere
Projects
None yet
Development

No branches or pull requests

5 participants