Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GaiaGuardianEntity & "gaia arena" seperation #4750

Open
megadoxs opened this issue Sep 6, 2024 · 0 comments
Open

GaiaGuardianEntity & "gaia arena" seperation #4750

megadoxs opened this issue Sep 6, 2024 · 0 comments
Labels
after-1.21-port This will not be fixed/implemented before the port to 1.21 enhancement Enhancement that might be implemented in the future investigate

Comments

@megadoxs
Copy link

megadoxs commented Sep 6, 2024

Issue description

This issue is more of a proposition of an improvement. Currently, all the methods that are related to the arena in which the player fights the Gaia are inside the GaiaGuardianEntity. My proposition would be to separate them or effectively remove all the methods that are related to the arena itself from GaiaGuardianEntity and move it to a new class (GaiaArena for example) that would hold all these methods. While this change not only simply makes sens, because after all the arena is not part of the entity, but used for its summoning, it would allow for addons to add their own bosses to the arena. To be fair, it is already possible for an addon to add a new boss to the "gaia boss fight arena", but for it to be done, a lot of methods from the GaiaGuardianEntity class have to be copied to reproduce the logic behind spawning the gaia if the arena is complete. So moving these methods that don't need to be inside GaiaGuarduanEntity and making them public instead of private, would simplify the process of adding a boss (like a third Gaia) to the arena that the Gaia uses.

@TheRealWormbo TheRealWormbo added investigate enhancement Enhancement that might be implemented in the future after-1.21-port This will not be fixed/implemented before the port to 1.21 labels Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
after-1.21-port This will not be fixed/implemented before the port to 1.21 enhancement Enhancement that might be implemented in the future investigate
Development

No branches or pull requests

2 participants