Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PetalApothecaryBlock Variants are useless - remove #4718

Open
artemisSystem opened this issue Jul 13, 2024 · 0 comments
Open

PetalApothecaryBlock Variants are useless - remove #4718

artemisSystem opened this issue Jul 13, 2024 · 0 comments
Labels
after-1.21-port This will not be fixed/implemented before the port to 1.21

Comments

@artemisSystem
Copy link
Member

Botania/Xplat/src/main/java/vazkii/botania/common/block/PetalApothecaryBlock.java

Lines 66 to 79 in 30dd003

public enum Variant {
DEFAULT,
FOREST,
PLAINS,
MOUNTAIN,
FUNGAL,
SWAMP,
DESERT,
TAIGA,
MESA,
MOSSY,
LIVINGROCK,
DEEPSLATE
}

These are not used for anything other than making names when registering the blocks - we can just remove them, but should be done in 1.21 since the constructor signature changing would be a breaking change
@artemisSystem artemisSystem added the after-1.21-port This will not be fixed/implemented before the port to 1.21 label Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
after-1.21-port This will not be fixed/implemented before the port to 1.21
Milestone
No milestone
Development

No branches or pull requests
1 participant
@artemisSystem