Enhancements for Neovim #1079
Enhancements for Neovim #1079
Conversation
This was required to reduce the vim <-> python serialization/deserialization overhead in Neovim. Vim should not be affected.
- Instead of calling BuildRequestData, EventNotification/SendEventNotificationAsync now receive request data as argument. - Methods of the YouCompleteMe can also optionally receive a request data
Use `push_message` method(Neovim-specific) to notify listeners of `ycmd_response` events. This will be used to asychronously update Neovim whenever a completion/compilation request is complete without relying on client-side polling.
| @@ -344,7 +362,14 @@ function! s:OnBufferVisit() | |||
|
|
|||
| call s:SetUpCompleteopt() | |||
| call s:SetCompleteFunc() | |||
| py ycm_state.OnBufferVisit() | |||
|
|
|||
| if s:is_nvim | |||
There was a problem hiding this comment.
You should abstract this behind a function like OnBufferVisitInternal or whatever. Then that would check for is_nvim and call send_event or ycm_state.OnBufferVisit.
Do something similar in other places where possible. I'd prefer to have the logic that picks send_event over python calls encapsulated.
|
Gave this a light review. Thanks for the PR! [Note to future self: review this more carefully before merging.] |
|
I've fixed some issues with the python client and now YCM now has no noticeable performance impact when compared to upstream vim, so these changes are unnecessary. Thanks for reviewing anyway! |
|
@tarruda are you sure that this should be closed? Does not this PR provide better performance in neovim than upstream vim? |
yes but Neovim is not yet 100% stable for accepting asynchronous API calls since some modes cant handle K_EVENT correctly yet. This might break if the call is received when confirming if a swap file should be loaded, for example. After neovim/neovim#974 is corrected and merged I might give async completions another try |
|
@tarruda Thank you for improving Neovim to the point where extensive changes to YCM are not needed. This will not only make maintaining YCM easier but should improve the performance of other Vim plugins that are written in Python and run inside Neovim. So thanks for that! I'm totally open to future Neovim-related PRs though. |
|
Hey, i'm trying to install YCM with Vundle on neovim but i can't make it working. It ask every time for Vim compiled with Python 2.x. Any idea? |
|
|
Oh, thank's ! |
|
@tarruda It looks like neovim/neovim#974 was solved by neovim/neovim#1316. Do you think NeoVim is ready for asynchronous completions in YouCompleteMe now? Thanks a ton! |
It should be possible to write a fully asynchronous YCM client for Neovim as a remote plugin. Here's a remote plugin example. |
|
I'd recommend focusing on having great support for vanilla YCM out-of-the box for neovim. YCM is probably the most complex Vim plugin out there so if that works well, other plugins should too. When neovim hits 1.0 and becomes more widely accepted as a Vim alternative, then we can take a look at a custom YCM client. In other words, I recommend taking it one step at a time. Small bites are better than bigger ones. |
|
@Valloric I completely understand not wanting to go nuts on changing YCM to support Neovim, but a 1.0 is probably a long way away. Is there something that can be done to start transitioning to async sooner? |
|
Any update here ? |
No, and personally I wonder what it would bring to the table feature-wise. |
|
to quote the reason this was closed by the author:
So what is the expectation of change? Are you seeing a problem with neovim? |
This PR contains some enhancements that will make YCM run better on Neovim, which uses a separate process for running python code.
Here's a summary of the changes:
send_eventfunction is used to notify the python process about events. This was done because thepythoncommand blocks Neovim until the python process responds.complete()vimscript is used to display completions asynchronously('omnifunc' is not touched)I've posted this for review, but it's not ready for merging yet. I'm still stabilizing the Neovim branch which supports python plugins, so there may be some minor changes to this code. I'm also going to improve commit messages and descriptions.