Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup a WebHook to automatically detect and trigger new VSCodium builds #264

Closed
cyfrost opened this issue Oct 11, 2019 · 5 comments
Closed

Comments

@cyfrost
Copy link

cyfrost commented Oct 11, 2019

Hi, thanks for working on VSCodium.

I noticed what might become an issue for many users of VSCodium: A few hours ago, MS released the recovery build (v1.39.1) for the September release of VSCode. I was trying to find the VSCodium builds for it but couldn't find it. After searching through the issues, I found a relevant answer from @stripedpajamas where you said that the "probe and cut new self-builds" process occurs once every 24 hours automatically. But wouldn't it be nice to have a GitHub Integration WebHook setup with VSCode's repo to automatically trigger and cut new builds without any delay? That'll help us get the newer builds almost at the same pace as upstream releases.

For instance, v1.39.1, which was out today, contained an important fix for a potential security vulnerability, so getting the update faster becomes all the more important.

@cyfrost cyfrost changed the title Use VSCode's GitHub releases webhooks to trigger builds automatically Setup a WebHook to automatically detect and trigger new VSCodium builds Oct 11, 2019
@stripedpajamas
Copy link
Member

👏 👏 👏

Completely agree; I will look into setting this up.

@stripedpajamas
Copy link
Member

@cyfrost actually I feel like I looked into this a while ago, but maybe I misunderstood the documentation. Isn't it true that only the repository owner can setup a webhook for the events that happen in that repository? In our case, we want notifications from the vscode repo to call a webhook that would trigger our VSCodium build on Travis.

@cyfrost
Copy link
Author

cyfrost commented Oct 31, 2019

@stripedpajamas Thanks for the reply. You're correct, only the owner of the repository can setup webhooks. We can try raising an issue at upstream asking them to setup a webhook for us but it may or may not happen.

Although for our testing purposes, I've setup an opensource mirror of VSCode on GitLab here. Since it's a mirror, all changes are updated automatically, and thanks to the "Tag Push Events" webhook available in the Integrations page, we can reliably tell new releases instantly and have Travis builds run as well.

For demo purposes, I've setup two simple webhooks of my mirror:

  1. This hook gets triggered on each commit pushed to master of upstream: Test the webhook here

  2. This hook gets triggered whenever there's a new release upstream: Test the webhook here

It's easy to send test events to trigger these hooks via this page > Test button. I've added you (on GitLab) as a repository maintainer of this mirror repo so you can test out the integrations, please let us know how it goes.

@cyfrost
Copy link
Author

cyfrost commented Nov 8, 2019

Update: today's release of v1.40 upstream has triggered our dummy webhook here, it is working as expected.

@stripedpajamas
Copy link
Member

Thank you for setting this up, @cyfrost; I think this will work perfectly. Action item to close out this issue would be to implement a handler (probably keeping the code in the github.com/vscodium org) that can be called from the Gitlab webhook that triggers Travis and Azure for builds.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants